cleanup ProxyProtocol and prevent memory leak #12680
Open
+352
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maskit
reviewed
Nov 20, 2025
maskit
reviewed
Nov 20, 2025
include/iocore/net/ProxyProtocol.h
Outdated
| #pragma once | ||
|
|
||
| #include "tscore/ink_memory.h" | ||
| #include <filesystem> |
Contributor
Author
There was a problem hiding this comment.
idk why my editor things filesystem is needed in this file... I'll clean that up
bneradt
reviewed
Nov 21, 2025
| REQUIRE(tlv.has_value()); | ||
| CHECK(tlv.value() == "test"); | ||
| } | ||
| // Object destroyed here - ASAN will catch any memory leaks |
bneradt
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the rule of 5 functions to ProxyProtocol to allow safe copy construction and assignment.
It also avoids a memory leak of the use of ProxyProtocol in HttpTransaction::State where it wasn't getting destructed (HttpSM has a State and is class allocated without the flag to run the destructor).
#12676 will fix the memory leak in a different way, but the rule of 5 is still needed where ProxyProtocol is copied.